search

browserify / sha.js

Streamable SHA hashes in pure javascript
Other
288 stars 60 forks source link

Cannot find module 'graceful-fs' from '.../node_modules/sha' #27

Closed maiermic closed 9 years ago

maiermic commented 9 years ago

If I require sha.js (1.3.0) in a browserify application, I get an error message: Cannot find module 'graceful-fs' from '.../node_modules/sha'

dcousens commented 9 years ago

@maiermic sha is a package by @ForbesLindesay (see https://www.npmjs.com/package/sha). If you want to use sha.js, you need to do npm install sha.js.

maiermic commented 9 years ago

Thanks. I found your github project, searched on npm for it and found sha (overseeing the missing .js). It would be useful to link to your npm release on github.

dcousens commented 9 years ago

28, feel free to PR.

maiermic commented 9 years ago

I tried to push my changes on a new branch to create an PR, but I get an error:

remote: Permission to crypto-browserify/sha.js.git denied to maiermic.
fatal: unable to access 'https://github.com/crypto-browserify/sha.js.git/': The requested URL returned error: 403
ForbesLindesay commented 9 years ago

You need to "fork" the project first (the button at the top right of the page on GitHub). This creates a separate copy of the repository that you have full access to. Then once you've pushed your changes to that copy you can create the pull request to ask your changes to be merged into this repo.