Closed fanatid closed 8 years ago
Very nice.
Nice loop unrolling. ACK. Haven't tested performance locally yet.
kudos @indutny
@dcousens I just add |0
to some variables, probably you skip them, unroll loops like in hash.js.
Also make benchmarks with unsigned.. signed is faster.
@fanatid that is a huge improvement over hash.js
though.
because signed is used (hash.js uses unsigned), inline some functions and as I understand |0
is faster than >>> 0
Verified performance improvement. Merging. @dominictarr please release :)
awesome great work!
On Tue, Feb 16, 2016 at 9:41 AM, Daniel Cousens notifications@github.com wrote:
Merged #34 https://github.com/crypto-browserify/sha.js/pull/34.
— Reply to this email directly or view it on GitHub https://github.com/crypto-browserify/sha.js/pull/34#event-551190373.
Can you publish package with this PR?
ping @dcousens
Significant performance improvement for sha, sha1, sha256 (sha512 not much): benchmark for sha256 (crypto-bench at daf5e83):
for current version of sha.js and hash.js here
/cc @dcousens @indutny