search

browserify / watchify

watch mode for browserify builds
Other
1.79k stars 181 forks source link

Update index.js #152

Closed Pleochism closed 9 years ago

Pleochism commented 9 years ago

Fixes bug with JSON requires from JS files not being modularised cleanly.

kumavis commented 9 years ago

I don't know what the side effects are, but this solves the issue I'm running into.

Pleochism commented 9 years ago

It definitely breaks grunt-browserify, sadly.

kumavis commented 9 years ago

@Pleochism any idea what the underlying issue is? and why this change solves it?

Pleochism commented 9 years ago

I don't. I'd guess that it's related to caching of files, but I can't determine what the cache/packageCache properties are used for further up the chain. Unfortunately I won't have time to look at this again for a few days.

zertosh commented 9 years ago

@Pleochism @kumavis Can you try 2.5.0? https://github.com/substack/watchify/pull/160 should have also fixed your issue

Pleochism commented 9 years ago

Yep, that did the trick. Works as expected via grunt-browserify as well.