browserify / watchify

watch mode for browserify builds
Other
1.79k stars 181 forks source link

no longer reloading #260

Open mattdesl opened 9 years ago

mattdesl commented 9 years ago

Using grunt-browserify with watch mode, wachify@3.3.1 does not reload on file change. If I cd into node_modules/grunt-browserify and npm install watchify@3.2.2 it reloads properly.

The code is private, but if I get a chance I will try to boil it down to a smaller test repo.

jennasalau commented 9 years ago

+1

domoritz commented 9 years ago

I can reproduce this issue at https://github.com/uwdata/vega-lite

With 3.3, gulp serve gets stuck. With 3.2 everything is fine.

jljorgenson18 commented 9 years ago

+1

zertosh commented 9 years ago

@mattdesl It's probably this https://github.com/substack/watchify/pull/250#issuecomment-126404248 https://github.com/substack/watchify/issues/256#issuecomment-130261185

zertosh commented 9 years ago

@domoritz I vega-lite at 49ee1ca with watchify 3.3.1 and it works. Maybe you had an old version browserify? Try removing the node_modules directory and reinstalling your packages.

jljorgenson18 commented 9 years ago

I updated Browserify from 11.0.0 to 11.0.1 and it started working again.

domoritz commented 9 years ago

Jup, works now in vega-lite with watchify 3.4.

mattymil commented 9 years ago

Still broken in 3.4.0

zertosh commented 9 years ago

@mattymil Can you open a new issue? Please include a way to reproduce the problem

mattymil commented 9 years ago

Will do.

On Sep 4, 2015, at 1:08 PM, Andres Suarez notifications@github.com wrote:

@mattymil https://github.com/mattymil Can you open a new issue? Please include a way to reproduce the problem

— Reply to this email directly or view it on GitHub https://github.com/substack/watchify/issues/260#issuecomment-137794939.

mightyiam commented 9 years ago

:+1:

ptmccarthy commented 9 years ago

I'm having the same problem with watch mode not working with watchify 3.4.0. Changes to watched files never trigger a recompile. This actually looks to have been introduced with watchify 3.3.1.

I'm using grunt-browserify 3.8.0, which uses browserify 10.2.6 and watchify 3.4.0.

My grunt-browserify tasks are straightforward, for example:

browserify: {
  options: {
    browserifyOptions: {
      debug: true
    },
    watch: true
  },

  reports: {
    src: [
      '<%= config.src %>/reports/js/main.js',
      '<%= config.src %>/reports/templates/*.hbs'
    ],
      dest: '<%= config.dist %>/reports/js/reports.js'
  }
}

If I manually downgrade watchify to 3.3.0 watch mode works just fine again, but 3.3.1 and above do not work. Regardless, that's not a great solution since the semver dependency of watchify in grunt-browserify is ^3.2.1 which will always download 3.4.0 from npm.

I know we are a few versions behind on browserify, but our dependencies are pinned at the project level for the time being.

zertosh commented 9 years ago

@ptmccarthy You need browserify 11.0.1+

asbjornenge commented 9 years ago

I've been having these issues for a long time now. Tried today with watchify 3.4.0, and let it pick it's own browserify 11.2.0. Still broken. Works a few times, then just stops working suddenly :disappointed:

Also tried 3.2.2 which works twice and then stops reloading. Weird.

Box Ubuntu 14.10 / Linux 3.17.4 (ext4) Node 0.12.2 & 4.1.1 (tried both) Npm 2.14.4

asbjornenge commented 9 years ago

Apparently, if I enable polling it works! --poll=100 and it's back :grin:

zertosh commented 9 years ago

@asbjornenge Then your issue is not with watchify but with chokidar.

zertosh commented 9 years ago

@mattdesl is this all cleared up?

zertosh commented 9 years ago

@vz8 That sounds like a chokidar issue

quentindemetz commented 8 years ago

Looks like the relevant issue has not been fixed in chokidar (https://github.com/paulmillr/chokidar/issues/395).

1j01 commented 8 years ago

:+1: I tried to use watchify and it was effectively just browserify.

mattdesl commented 8 years ago

@1j01 Are you still affected by this?

For what it's worth, I haven't seen this problem recently.

1j01 commented 8 years ago

@mattdesl Let me see... Yes.

PaulAik commented 8 years ago

Looks like I'm experiencing this issue also.

The chokidar issue looks to have been closed.

Anything we can do to provide further clarification on the root cause?