search

browserify / watchify

watch mode for browserify builds
Other
1.79k stars 203 forks source link

Escaping spaces / parentheses in file paths #331

Closed rickyc closed 7 years ago

rickyc commented 7 years ago

I don't think this is the most elegant solution, but I'm not too familiar with node. I was running into the problem where watchify was breaking for the following path.

/users/rickyc/Example (GitHub)/something

This was a quick monkey patch to fix the issue. After tracing it this far, I noticed that this could probably be fixed in chokidar as well and going even further into fs.

Thoughts as to how I can clean this logic up?

lorenzos commented 7 years ago

This is a chokidar issue, as you guessed. They are working on it, and it will be "automatically" fixed when they update the is-glob dependency, I hope in days.

rickyc commented 7 years ago

Ahhh, thanks!

On Tue, Oct 4, 2016 at 3:13 PM Lorenzo Stanco notifications@github.com wrote:

This is a chokidar issue, as you guessed. They are working on it https://github.com/paulmillr/chokidar/issues/300, and it will be "automatically" fixed when they [update the is-glob] dependency, I hope in days.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/substack/watchify/pull/331#issuecomment-251484342, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG0kTJ_DIgF92KQXtQCdJ1XGsuDndzlks5qwqVVgaJpZM4KN9YO .