search

browserify / watchify

watch mode for browserify builds
Other
1.79k stars 181 forks source link

Avoid deprecation in upcoming version of node #345

Closed mscdex closed 7 years ago

mscdex commented 7 years ago 
 fs.js:101
     throw new (lazyErrors().TypeError)('ERR_INVALID_CALLBACK');
     ^
 TypeError [ERR_INVALID_CALLBACK]: callback must be a function
     at maybeCallback (fs.js:101:11)
     at Object.fs.writeFile (fs.js:1228:14)
     at /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/39252caf-563e-48c1-996a-8955580a49e0/watchify/test/bin.js:30:20
     at Socket.<anonymous> (/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/39252caf-563e-48c1-996a-8955580a49e0/watchify/test/bin.js:48:9)
     at emitNone (events.js:110:20)
     at Socket.emit (events.js:207:7)
     at endReadableNT (_stream_readable.js:996:12)
     at _combinedTickCallback (internal/process/next_tick.js:102:11)
     at process._tickCallback (internal/process/next_tick.js:161:9)

Similar changes may/may not need to be made elsewhere, this was at least the first instance I noticed when running this project's tests in node's citgm.

mscdex commented 7 years ago

Oops, didn't see that https://github.com/substack/watchify/pull/345 was already submitted. Closing...