search

browserify / watchify

watch mode for browserify builds
Other
1.79k stars 181 forks source link

Bump chokidar to 0.10.2 #98

Closed es128 closed 10 years ago

es128 commented 10 years ago

@paulmillr recently handed the reins over to me on chokidar, and I've made a whole bunch of improvements to the stability and consistency of how it emits events.

Should be able to close several open issues with this: (#23, #81, #82, #84, #97)

paulmillr commented 10 years ago

:+1:

paulmillr commented 10 years ago

@substack

ghost commented 10 years ago

+1

es128 commented 10 years ago

Updated. The merge of #102 had created conflicts.

mafintosh commented 10 years ago

Added in 0a745d8. Thanks for the fix.

mafintosh commented 10 years ago

@es128 You should bump chokidar to 1.0.0 on npm. That way patches/minor bumps gets pulled in automatically.

paulmillr commented 10 years ago

Not really. Chokidar wants to follow semver. We bumped major release because it may have introduced backwards-incompat changes.

mafintosh commented 10 years ago

@paulmillr Semver behaves differently on version <1.0.0. This PR wouldn't be needed if chokidar was on 1.0.0 and we used a ^1.0.0 semver in our dependencies. As long as chokidar in on <1.0.0 we need to explicitly bump everytime there is a minor update.

es128 commented 10 years ago

@mafintosh yes I've thought about it, but there are a few more features I want to introduce before bumping to 1.0.0 and locking in the API. Soon.

mafintosh commented 10 years ago

@substack could you patch bump?