browserify / webworkify

launch a web worker that can require() in the browser with browserify
Other
417 stars 39 forks source link

[Edge browser] With URL.revokeObjectURL no message is received in the worker #26

Closed ghost closed 8 years ago

ghost commented 8 years ago

V1.2.1 no longer working in Edge browser. V1.2.0 works fine.

anandthakker commented 8 years ago

@cnsdato Thanks for the report. I guess maybe Edge is loading the worker source asynchronously? Not exactly sure. Ways we could deal with this:

@substack preferences?

anandthakker commented 8 years ago

Going with (IMO) the simplest approach, which is to just attach objectURL to the returned worker so that user code can decide if/when to revoke it.

anandthakker commented 8 years ago

@cnsdato Just pushed what I believe should be a fix for this and published as 1.3.0. It would be great if you could confirm?

ghost commented 8 years ago

@anandthakker Thanks for fixing this, I will give it a try in the next few days and will give you response on this.

Edit: looks good so far.

mourner commented 8 years ago

This was fixed.