search

browserify / wzrd.in

browserify as a service.
http://wzrd.in
MIT License
638 stars 96 forks source link

Added scoped module support #112

Closed gregtatum closed 8 years ago

gregtatum commented 8 years ago

From #104 this adds scoped module support. Please review and let me know if there is anything I need to change as this code-base was all new to me, but hopefully I got everything. The biggest question-mark on this PR is that I had to bump the npm version to support scoped modules.

jfhbrook commented 8 years ago

Jesus, this has been using npm 1?? Wow. I still use npm 2, but maybe npm 3 is better for browserify builds?

jfhbrook commented 8 years ago

FTR npm 1 doesn't support scoped modules, but npm 2+ does.

jfhbrook commented 8 years ago

@maxogden what do you think? I think npm 3 is fine but that we should encode the slash in the package name.

@TatumCreative this is great, thank you.

max-mapper commented 8 years ago

I'm personally -1 on npm 3, I'd stick with whatever npm ships with the LTS version of node (2.x currently) just to minimize potential bugs

gregtatum commented 8 years ago

Ok, I updated the forward slash to a %2F and did npm down to v2.14.15. Let me update the docs real quick, so that people know to do the %2F for scoped modules. Let me know if there is anything else!