browserify / wzrd.in

browserify as a service.
http://wzrd.in
MIT License
636 stars 96 forks source link

GET /multi/:id doesn't seem to work #170

Open danieldunderfelt opened 7 years ago

danieldunderfelt commented 7 years ago

Hi!

I'm in the process of building something with wzrd.in (great service!), but retrieving multi-bundles doesn't seem to work.

First, I posted to /multi:

{
  "dependencies": {
    "react": "15.5.4",
    "react-dom": "15.5.4"
  }
}

That worked, and I got the response with the two packages and the bundles. I also found the location in the headers. But when I try to retrieve the multi-bundle, all I get is "Bundle not found, have you tried POSTing to /multi".

Is this broken, or am I doing something wrong?

Here's the url I'm trying to fetch: https://wzrd.in/multi/b4e028f7b3be57e6572282cb26a89602

jfhbrook commented 7 years ago

I think https://github.com/jfhbrook/wzrd.in/blob/master/multiple.js#L121 this line is wrong.

jfhbrook commented 7 years ago

We hash both here https://github.com/jfhbrook/wzrd.in/blob/master/bundler/cache.js#L33 and here https://github.com/jfhbrook/wzrd.in/blob/master/bundler/cache.js#L18 so we may be hashing some inputs twice and others only once...

It's unknown if this is an issue with the docker branch.

I don't have the bandwidth to develop and push out a fix right now, just so I don't get your hopes up. :)

danieldunderfelt commented 7 years ago

Ok, thanks for looking into it!

I can probably do with separate bundles. Do you think bundle sizes will be much different between separate bundles added together and one multi-bundle?

jfhbrook commented 7 years ago

Shouldn't be

danieldunderfelt commented 7 years ago

Great, thanks!

lufinkey commented 6 years ago

Is there any update on this? I'm having this issue as well