search

browserify / wzrd.in

browserify as a service.
http://wzrd.in
MIT License
637 stars 96 forks source link

save/report build statuses #39

Closed airportyh closed 10 years ago

airportyh commented 11 years ago

See the README.md for API info.

One implementation detail to note is that I factored out a SubCache "class" in cache.js, the goal of which is to allow lower level access to the database for saving the build statuses - which now I realize do not really use the cache semantics at all. Whereas before, you'd use c.<subdb name>(...), now you should use c.<subdb name>.check(...) to perform the normal cache query.

This might be a bit rough, so few free to critique.

jfhbrook commented 11 years ago

Cool! I haven't had the time to review the code yet, but I'm really happy to see this PR.

airportyh commented 11 years ago

Made a short demo http://www.screenr.com/mlGH (1:39).

jfhbrook commented 11 years ago

Just an update: Still excited about, and trying to make time for, this PR.

jfhbrook commented 11 years ago

This looks pretty good. I'm gonna make a few comments about code style and some things I want to implement for the next release incorporating this change. You don't have to feel obligated to deal with any of them; I'll do them eventually. :)

jfhbrook commented 10 years ago

I ended up reimplementing this after making a number of refactors, here: https://github.com/jesusabdullah/browserify-cdn/pull/63 . Behavior is a bit different, but the general idea is the same and this PR was a great reference.

Thanks! Sorry this took so long. The README on master should have reasonable docs for the builds API.

airportyh commented 10 years ago

Sweet! Let me know when you go live with it.