search

browserify / wzrd.in

browserify as a service.
http://wzrd.in
MIT License
637 stars 96 forks source link

npm-publish-stream causes crashes if npm goes down #68

Closed max-mapper closed 10 years ago

max-mapper commented 10 years ago

from a wzrd.in downtime today:

Error: Got status code 500
    at ClientRequest.<anonymous> (/home/max/src/browserify-cdn/node_modules/npm-publish-stream/npm-publish-stream.js:21:32)
    at ClientRequest.g (events.js:175:14)
    at ClientRequest.EventEmitter.emit (events.js:95:17)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (http.js:1658:21)
    at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:119:23)
    at Socket.socketOnData [as ondata] (http.js:1553:20)
    at TCP.onread (net.js:525:27)

in production its designed to restart but it will crash if it flaps. it seems like it was getting 500s from NPM which caused it to flap. this seems like it will be a matter of handling 500s in a non-crashy way

jfhbrook commented 10 years ago

Okay, I'll try to take a look between scary scary NYC apartment hunting.

jfhbrook commented 10 years ago

So is https://github.com/jesusabdullah/browserify-cdn/commit/14a846598e9a35e59d36f3a8b86c92eb6f9e9490 flawed?

max-mapper commented 10 years ago

fixed in https://github.com/jesusabdullah/browserify-cdn/commit/b7ddca593c7cbc7279ab3b2e930248a4b0e4698d