Fix AVX2 detection on macOS

jelmervdl commented 2 years ago

Update AVX2 detection script to properly support macOS

Description

This is a fix for Marian's FindSSE.cmake script: https://github.com/marian-nmt/marian-dev/issues/880

List of changes:

also queries machdep.cpu.leaf7_features on macOS when searching for CPU features

Added dependencies: none

How to test

mkdir build
cd build
cmake .. | fgrep AVX2

Checklist

[x] I have tested the code manually
[ ] I have run regression tests
[ ] I have read and followed CONTRIBUTING.md
[ ] I have updated CHANGELOG.md

snukky commented 2 years ago

Woops, I was thinking that this is a branch in browsermt/marian-dev but opened towards marian-nmt/marian-dev and allowed myself to update the changelog (actually it's quite nice it can be done via the GitHub UI easily). Feel free to undo this change or keep it and open a PR against marian-nmt/marian-dev too.

XapaJIaMnu commented 2 years ago

@jerinphilip we really shouldn't be relying on the MacOS fork being compiled with a wrong architecture just for the tests. If you want tests to only pass on avx (or ssse3), we should fix --DBUILD_ARCH

browsermt / marian-dev