browsermt / marian-dev

Fast Neural Machine Translation in C++ - development repository
https://marian-nmt.github.io
Other
20 stars 7 forks source link

Allow compilation without the presence of .git directory #97

Closed kroketio closed 1 year ago

kroketio commented 1 year ago

Description

src/CMakeLists.txt:145 does not allow compilation without the presence of a .git directory (or file).

This means that any marian-dev compile must always come from a git clone which is problematic for us as we are distributing marian-dev in a Python wheel package that, preferably, does not ship with .git directories.

List of changes:

How to test

I have replaced the version with "unknown" when the git revision could not be established so that compilation may continue.

$ build/marian --version
v1.9.56 unknown