browserpass / browserpass-extension

Browserpass web extension
ISC License
840 stars 51 forks source link

Not possible to fill password when web components are used #266

Open wiktor-k opened 3 years ago

wiktor-k commented 3 years ago

General information

Exact steps to reproduce the problem

  1. Go to https://dashboard.nexmo.com/sign-in

  2. Try to use browserpass to fill the password

What should happen?

Password gets filled in.

What happened instead?

I see Error: Error: No fillable forms available for fields: login, secret

I guess this is because the site uses Web Components instead of raw inputs but the controls that they use respond to standard methods: $(".password").value='x' works fine.

maximbaz commented 3 years ago

Thanks! I presume this is a duplicate of #73, but definitely an important case to solve 👍

wiktor-k commented 3 years ago

Hi @maximbaz, thanks for the reference!

Actually to solve this issue no shadow DOM support is needed. I guess the filter is too aggressive and wants input fields (or textarea) where it could just query by name / selector for password and then check if ('value' in element) to make sure that the element is writable.

73 would most certainly solve this one too but it's not strictly necessary.