browserpass / browserpass-extension

Browserpass web extension
ISC License
825 stars 50 forks source link

Should not fill the domainname into username fields #303

Open gaaf opened 1 year ago

gaaf commented 1 year ago

The extension should not default to filling the domainname(=filename) into username fields. If no username is present in the password file and there is no default username, it is of no use to enter the filename instead.

Exact steps to reproduce the problem

  1. Fill in username info a form

  2. Use browserpass to lookup and fill the password

  3. The previously entered username is overwritten with the filename of the password file

What should happen?

In absence of a username in the password file and absence of a default password, don't touch the username field of the form.

Even if I can not think of a scenario where one would want the domainname(filename) filled in the username field, maybe make it optional.

What happened instead?

  1. The previously entered username is overwritten with the filename of the password file
maximbaz commented 1 year ago

Hello, some people do in fact put usernames as the file names, you can read more about the logic of choosing in this documentation section:

https://github.com/browserpass/browserpass-extension#organizing-password-store

If there's a particular entry you'd want to fix, you can add a line user: to it, and thus only the password would be filled.

Also #267 could be relevant.