browserpass / browserpass-extension

Browserpass web extension
ISC License
825 stars 50 forks source link

Implement Remaining Keyboard Navigation For Add/Edit UI #306

Open patgmiller opened 1 year ago

patgmiller commented 1 year ago

Below is a reference to the conversation about missing keyboard navigation. Here is a link to beginning of the original conversation.


    I think generally I don't have a strong opinion on the arrow navigation, because personally I always use Tab / Shift-Tab. On the main screen I might have to use arrows left and right once I reach the desired entry, but that in my mind is very intuitive. Arrows Up and Down there for me personally are just a neat bonus 🙂  

Having said that, I have a stronger preference for generally being able to do everything with keyboard, where right now for example I can reach the "View credentials" page, but not further. But I would be more than happy to have a separate ticket to revisit keyboard navigation across the extension.

In this particular case, I also agree with @patgmiller that I would maybe find it not intuitive that arrows up and down could be used until you reach a multi-line textarea, after which you are stuck inside and have to anyway use Tab / Shift-Tab to get out (unless we implement something custom that will allow to sometimes escape textarea using arrows up and down?). But maybe I just lack experience / imagination - I'm not against arrow navigation if it's intuitive! 😄

_Originally posted by @maximbaz in https://github.com/browserpass/browserpass-extension/pull/290#discussion_r987394629_