Closed uninsane closed 1 year ago
fixed, thanks for linking to the code path! tested just with and without enableOTP
in the store settings this time, assuming if that works it should all work.
@maximbaz any movement on this? i'd like to move onto other browserpass work before life gets busy, but i'm not the type to maintain a dev branch that diverges from upstream in more than one direction at a time.
Sorry for the delay and that it blocks the further development, @erayd what do you think about this, would you have time to have a look here?
@maximbaz I missed this one sorry - I've taken a look, and I'm happy for it to be merged from a code standpoint. I haven't actually tested it - but if you are happy with the behavior, then feel free to merge 🙂.
With a reservation of me not being the typical user of OTP functionality in Browserpass, I think the behavior did make sense to me, and I'm happy that we fixed an inconsistency and gained the more intuitive behavior 🙂 Let's merge, and if you spot a regression later, we can always revisit 👍
the README.md says:
this makes it sound like one should be able to set
enableOTP = true
inside a store's config and leave it unset at the extension level, which sounds intuitive. but when i try that on master i'm not shown any token. unless i've missed something, the code only attempts to read this from the extension-level settings. this PR fixes that to match the behavior of the readme.tested manually:
.browserpass.json
-> shows token"enableOTP": false
in store -> no token"enableOTP": true
in the store level -> shows tokenenableOTP
from the store config, setenableOTP: true
in a secret -> no tokeni'm a novice JS dev, so if i'm breaking idioms with my approach here don't hold back in setting me straight 😉