search

browserpass / browserpass-extension

Browserpass web extension
ISC License
825 stars 50 forks source link

Feature Request: add `note on OTP` link to config dialog #317

Open juchem opened 1 year ago

juchem commented 1 year ago

General information

The config dialog states that enabling OTP is not recommended with no explanation of why, which can be quite confusing (e.g.: is OTP not recommended or what?).

The github repo has a very nice and informative note about why that is the case, but one has to know about it to look for it. It took me a long time to find that note out.

What should happen?

This is a feature request to add a link to the note on OTP (perhaps on the not recommended text) to the config dialog, for easier discoverability. Bonus points if hoving over it gives out a brief explanation, suggesting the link for further info.

maximbaz commented 1 year ago

Thanks for sharing your experience! This kind of feedback is important to have.

Your suggestion makes a lot of sense to me. Would you like to send a PR?

juchem commented 1 year ago

@maximbaz I'd love to. I took a stab at it and realized I'd have to learn way more about the JS framework browserpass uses than I can afford to. I might try again on a rainy day but, realistically, this is likely not going to happen any time soon.

The next best thing I could do was to give a detailed report with links to the part of the source code where I believe the change has to be made.

I understand I'm not being the most helpful. I'm genuinely sorry about it, and thankful for this great extension.

maximbaz commented 1 year ago

No worries at all, your idea is already a valuable contribution! We'll get to this at some point :+1: