search

browserpass / browserpass-extension

Browserpass web extension
ISC License
825 stars 50 forks source link

Weird layout #327

Closed ayykamp closed 9 months ago

ayykamp commented 9 months ago

General information

Exact steps to reproduce the problem

  1. Open Extension pop up

  2. Have any passwords with a long path

What should happen?

See passwords normally

What happened instead?

image image

mcexit commented 9 months ago

I've been having this issue too for a while after a Chromium update. I recall a similar issue in the past where a fix was implemented. Prob just requires some changes to the CSS or JS. The commit history should show what changes were done before to fix it. It is annoying, but still functional.

I haven't any activity on this project in a while. If the author is still around and doesn't have time to address this, please let me know and I'll try to get a PR submitted tonight. If the project is abandoned, then I'm happy to take over if no one else wants to.

I have been learning modern JS and have some limited experience with browser extensions. I'm certain that I can at least fix this issue, and may be able to make some further improvements in the future. I absolutely rely on this extension though and have preferred it over the gopass alternative.

erayd commented 9 months ago

I haven't any activity on this project in a while. If the author is still around and doesn't have time to address this, please let me know and I'll try to get a PR submitted tonight. If the project is abandoned, then I'm happy to take over if no one else wants to.

It's not abandoned, but I'm extremely short on time (and I think @maximbaz might be also?). If you'd be willing to fix this issue, it would be greatly appreciated - thank you!

maximbaz commented 9 months ago

PR would certainly be appreciated, thanks!

mcexit commented 9 months ago

@maximbaz @erayd I've submitted a PR which fixed the issue on Chromium.

erayd commented 9 months ago

Thanks @mcexit - much appreciated. #328 is merged.