Undocumented shortcut for opening a website

[rapidcow]

Hi, this isn't any specific bug so I'll just jump to my question. I was reading the Modal HTTP authentication section of README.md and was confused about what it meant by opening a website with Browserpass:

If you want Browserpass to handle modal authentication, you must open these websites using Browserpass.

After a bit of digging, I found that pressing Ctrl+G was how you open one from popup/interface.js L310-314:

function keyHandler(e) {
    /* start of my quoted code */
    switch (e.code) {
        case "KeyG":
            if (e.ctrlKey) {
                this.doAction(e.shiftKey ? "launchInNewTab" : "launch");
            }
            break;
    }
    /* end of my quoted code */
}

Was this obvious or is this something that needs clarification in the README?

[maximbaz]

Hello! The key shortcuts are documented in this section:

https://github.com/browserpass/browserpass-extension#available-keyboard-shortcuts

But a PR with a suggestion on how to make it clearer is definitely welcome - perhaps a link to that section? What do you think?

[rapidcow]

Dang I apologize for the oversight, I think I would have seen that if I read linearly or just did a simple search :c

That said I do think it helps to pack relevant information in that section for those who want to get an idea of what the url field is for. I made a PR for just that change: #333

[maximbaz]

Nice and clean, thanks, merged 👍

[rapidcow]

Thank you for your promptly replies too! I am impressed to see how well-maintained this project is :)