search

browserpass / browserpass-extension

Browserpass web extension
ISC License
825 stars 50 forks source link

Fix typos in source code comments #334

Closed rapidcow closed 8 months ago

rapidcow commented 8 months ago

Hi, it's me again. While I was scouring the source code yesterday I came across the word "Compule" which I didn't quite understand... I suppose it meant "Compute"?

And because I felt bad about just making a one-line change again I ran a spell checker on all other files and corrected those too, yeah 😬 please let me know if my changes were acceptable....

erayd commented 8 months ago

Thanks @rapidcow - I appreciate it. I know what you mean about not wanting to submit a PR for just one spelling correction; I have the same hesitation. Thanks for submitting this larger one which corrects several of them all at once 😁

rapidcow commented 8 months ago

Yes :'D and honestly it felt worse given that the fix wasn't even any serious code fix. But I'm glad to help what's within my capability!

erayd commented 8 months ago

It's better for it not to be a code fix, to be honest. Bulk spelling is easy to review and approve, and doesn't end up being mixed in the commit log with functional code changes.