browserpass / browserpass-extension

Browserpass web extension
ISC License
845 stars 52 forks source link

Extension prompting for "Update native host app" #337

Closed comatory closed 8 months ago

comatory commented 9 months ago

General information


If you are getting an error immediately after opening popup, have you followed the Configure browsers documentation section?

I'm not getting errors when opening the popup.


Exact steps to reproduce the problem

  1. Open the popup

  2. See the message "Update native host app"

  3. Make sure browserpass-native is up-to-date

  4. Re-open the popup

What should happen?

The message should not be present

What happened instead?

The message is present

maximbaz commented 9 months ago

Hello! This could either mean that you got an older version of the native host installed (an issue in the homebrew formula), or that you have two browserpass installations in different locations, and the browser is configured to pick up the old one.

The homebrew formula suggests to use this command to configure the browser: make hosts-firefox-user. So let's assume that's how you did it.

Here's what would get executed: https://github.com/browserpass/browserpass-native/blob/ed246ee62824a49a16e50482889f11f4e18b6934/Makefile#L466-L469

Open that json file, you'll see a full path to the browserpass binary. Is that the location of the browserpass binary that you'd expect? What version does that binary report?

You can manually edit the path in that json file, pointing to a correct binary (you can even grab one from the latest release), and see if the issue disappears.

If you confirm the issue with packaging, I would recommend to share your findings with the author of the formula, to hopefully prevent others from experiencing the same issue.

comatory commented 8 months ago

Hi 👋 Thanks for the detailed instructions, it helped me to debug it. I'm not sure what I did wrong before but for some reason I was still on 3.0.8. Maybe something happened meanwhile but when I ran upgrade for browserpass today, it correctly bumped the version. Then I just ran the make script and now it's working. Thank you for your help!

maximbaz commented 8 months ago

Awesome, enjoy the extension! 😊