browserpass / browserpass-extension

Browserpass web extension
ISC License
825 stars 50 forks source link

Page load speed drop #342

Open nikicat opened 4 months ago

nikicat commented 4 months ago

Hello, I've recently decided to switch to the Pass from KeepassXC and chosen Browserpass as a browser integration addon. Unfortunately, I've noticed a significant performance drop when loading sites (YouTube for example) after I've imported all my passwords to the pass database (~6.4K entries). When I disable Browserpass the page load time comes back to normal. When I run the Firefox profiler it shows that CPU time is spent inside the Browserpass extension.

image

General information

Exact steps to reproduce the problem

  1. Open YouTube with browserpass enabled and a pretty big password database.
  2. Observe a slower page loading speed.

What should happen?

In my opinion, Browserpass should not analyze the page until a user interacts with the extension. If this contradicts Browserpass' design at least I suppose that page load speed should not depend on the database size.

What happened instead?

I've observed a slower page load speed.

maximbaz commented 4 months ago

Thanks for sharing all the details!

My immediate impression is that it will likely be solved by this forgotten PR https://github.com/browserpass/browserpass-extension/pull/230 - @erayd shall we have a fresh look at that?

nikicat commented 4 months ago

@maximbaz Thank you for your rapid answer! I can confirm - when I installed the extension from #230 and enabled the "Hide badge counter" checkbox the performance drop disappeared. When I disable the checkbox the performance drop is back again.

BastienDurel commented 3 months ago

since a few days/weeks, I noticied the plugin-in often get stuck on loading login list :

image

I have to close/reopen the menu, often more than once, to get my list :/ Can this be related ?