Sub directories not matched

browserpass / browserpass-legacy

Legacy Browserpass repo, development is now happening at:

https://github.com/browserpass/browserpass-extension

MIT License

1k stars 80 forks source link

Sub directories not matched #182

Closed soullivaneuh closed 6 years ago

soullivaneuh commented 7 years ago

General information

Operating system + version: Ubuntu 17.04
Browser + version: Chrome Version 61.0.3163.100 (Official Build) (64-bit)
If installed an official release, put a release version: 2.0.8

Exact steps to reproduce the problem

With the following store map:

github
├── JoJo
└── Soullivaneuh
    └── pass

Search about github term on the extension.

What should happen?

Having github/JoJo and github/Soullivaneuh/pass result.

What happened instead?

Just having github/JoJo.

maximbaz commented 7 years ago

That's an interesting use-case. In principle I don't see any reason why not 🙂

Since it is a community project, it will be implemented only if you or someone else from the community decides to help out and provide a pull request. I'll be happy to test and review the code.

The relevant bit of code:

https://github.com/dannyvankooten/browserpass/blob/d0619e5d35b0f4e269df5c2cd7abfcbc5d3cd7e0/pass/disk.go#L45-L47

soullivaneuh commented 7 years ago

Well at least the issue is created. I don't have time right now, maybe later. :wink:

bhhaskin commented 6 years ago

~It would be nice to be able to search subdirectories for domains as well.~

~I.e. personal/github.com/user; work/github.com/user~

nvm! looks like this is already a thing!

maximbaz commented 6 years ago

This is already supported, I use exactly that configuration:

maximbaz commented 6 years ago

Thanks to @apropostech for implementing this feature, will release v2.0.9 soon.