search

browserpass / browserpass-legacy

Legacy Browserpass repo, development is now happening at:
https://github.com/browserpass/browserpass-extension
MIT License
999 stars 80 forks source link

Run prettier through yarn for consistency #236

Closed belak closed 6 years ago

belak commented 6 years ago

My first attempt to build this after some updates resulted in this, which is how I found this issue:

% make
yarn
yarn install v1.5.1
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
    2 {¬
[4/4] Building fresh packages...
Done in 1.27s.
dep ensure
prettier --write "chrome/*.js"
bash: prettier: command not found
make: *** [prettier] Error 127

The Makefile currently assumes that prettier is installed globally, however it's included in the package.json so it's installed in node_modules. Using yarn run will allow us to run prettier without having to modify the PATH to include it (or have to specify the full path manually).

Technically speaking, it isn't required to include prettier in scripts but I couldn't find that behavior documented anywhere so I went with the explicit definition.

maximbaz commented 6 years ago

Nice, thanks!