browserpass / browserpass-legacy

Legacy Browserpass repo, development is now happening at:
https://github.com/browserpass/browserpass-extension
MIT License
1k stars 80 forks source link

Copy OTP button added to the search results #257

Closed myelsukov closed 6 years ago

myelsukov commented 6 years ago

Changes to be committed: modified: chrome/background.browserify.js new file: chrome/icon-otp.svg modified: chrome/script.browserify.js modified: chrome/styles.css Icon is pulled from https://github.com/danklammer/bytesize-icons/blob/master/dist/icons/clock.svg

erayd commented 6 years ago

@maximbaz What if we added a right-click menu, which loaded the file before displaying, so that we know which options are available?

We can't decrypt every file to figure out which buttons to display (because decryption is slow), but we can certainly decrypt one.

maximbaz commented 6 years ago

I like that, noted for v3 😉

myelsukov commented 6 years ago

Suggested changes have been implemented. Please review.

myelsukov commented 6 years ago

My pleasure!