browserpass / browserpass-legacy

Legacy Browserpass repo, development is now happening at:
https://github.com/browserpass/browserpass-extension
MIT License
999 stars 80 forks source link

Open URL meta-field is being ignored #262

Closed uri closed 6 years ago

uri commented 6 years ago

General information


Exact steps to reproduce the problem

  1. Create a multiline entry in pass with a Open Url meta field.
# example.com.gpg
password1
username: my-name
url: https://example.com/login
  1. Invoke extension via keyboard shortcut (cmd+l in my case)
  2. Find this entry
  3. Tab, g

What should happen?

Browser should navigate to https://example.com/login

What happened instead?

Browser navigates to https://example.com

maximbaz commented 6 years ago

I cannot reproduce, my best guess is that an old binary is still alive somewhere on your system at takes over the new binary.

Check the manifest file in either /Library/Google/Chrome/NativeMessagingHosts or $HOME/Library/Application Support/Google/Chrome/NativeMessagingHosts, look to which browserpass binary it points. Then try to run that binary with -v and check the version.

Another test to do is to rename your file from example.com.gpg to example.gpg, my guess is that extension will complain on the absence of the url property in the file, possibly because of the old host app.

uri commented 6 years ago

I found a file in $HOME/Library/Application Support/Google/Chrome/NativeMessagingHost

  1. com.dannyvankooten.browserpass.json points to a binary that has the version: Browserpass host app version: 2.0.21
uri commented 6 years ago

I see what's happening. The login URL I was using was actually redirecting me without me noticing! My bad.