browserpass / browserpass-legacy

Legacy Browserpass repo, development is now happening at:
https://github.com/browserpass/browserpass-extension
MIT License
999 stars 80 forks source link

Missing prompt for GPG key (?) #265

Closed comatory closed 6 years ago

comatory commented 6 years ago

General information

Exact steps to reproduce the problem

  1. Do not use pass for some time
  2. After some time, decrypting passwords require my GPG key password
  3. When trying to use browserpass extension, it reports:
exit status 2 gpg: no secret key found

What should happen?

I'm not sure if this is correct behaviour but maybe a password prompt should popup asking for my GPG password.

What happened instead?

Displayed error.

maximbaz commented 6 years ago

Hi, this should work, but it seems you are using a very old version of the host app - please install the latest version and let me know if you still have the issue.

comatory commented 6 years ago

Oh I see. I will try to update then.

comatory commented 6 years ago

OK so by the host app you probably mean browserpass host app, not pass itself, right?

maximbaz commented 6 years ago

Correct, download here.

browserpass doesn't use pass at all by the way, only gpg to decrypt files 🙂

comatory commented 6 years ago

So in that I case I went here and downloaded latest release.

maximbaz commented 6 years ago

Yep, that's the one. Make sure to remove the old binary, there was a case when someone had two binaries installed and the old one took precedence.

comatory commented 6 years ago

Well that's the version I actually installed it with so I have no other binaries. It does not seem to work. How would I check (just in case) I have two binaries of the host app?

maximbaz commented 6 years ago

The file /etc/opt/chrome/native-messaging-hosts or $HOME/.config/google-chrome/NativeMessagingHosts should have a full path to browserpass binary (you likely only have one of these files), copy the full path and execute /full/path/to/browserpass -v - should print the version 2.0.21.

comatory commented 6 years ago

OK so I located file com.dannyvankooten.browserpass.json at /Users/$USER_NAME/Library/Application Support/Google/Chrome/NativeMessagingHosts. I looked into it, it looks like this:

{
  "name": "com.dannyvankooten.browserpass",
  "description": "Browserpass binary for the Chrome extension",
  "path": "/Users/<user_name>/Documents/browserpass-darwinx64/browserpass-darwinx64",
  "type": "stdio",
  "allowed_origins": [
    "chrome-extension://naepdomgkenhinolocfifgehidddafch/",
    "chrome-extension://klfoddkbhleoaabpmiigbmpbjfljimgb/"
  ]
}

when I use the path like this /Users/<username>/Documents/browserpass-darwinx64/browserpass-darwinx64 -v it gives me: Browserpass host app version: 2.0.21

Btw I'm using Chrome with two user profiles. Both of them have browserpass extension.

maximbaz commented 6 years ago

Awesome, so what's the current status, is everything good, is everything the same as before upgrading, is it worse? 🙂

comatory commented 6 years ago

It's still the same. I get the same message. When I unlock password using pass then it works fine.

comatory commented 6 years ago

Could this be caused by some kind of settings on the GPG key itself? I just don't get any prompt to unlock the GPG key from the extension itself.

maximbaz commented 6 years ago

I have a suspicion that you are experiencing some kind of variation of #13, try these steps from FAQ: https://github.com/browserpass/browserpass#does-not-work-on-macos-native-host-has-exited

comatory commented 6 years ago

OK I followed FAQ and it is fixed now. I had to create ~/.gnupg/gpg.conf and ~/.gnupg/gpg-agent.conf files though but it's all good now it seems. Thanks.

maximbaz commented 6 years ago

Awesome!