browserpass / browserpass-legacy

Legacy Browserpass repo, development is now happening at:
https://github.com/browserpass/browserpass-extension
MIT License
999 stars 80 forks source link

Problem with submitting AWS login page #268

Closed edwlarkey closed 5 years ago

edwlarkey commented 6 years ago

General information


Exact steps to reproduce the problem

  1. On AWS login page (for IAM user, not root)
  2. Fill and submit with browserpass

What should happen?

I should be logged into AWS or taken to a 2 factor auth page

What happened instead?

I get a page with a json error

{"state":"FAIL","properties":{"Message":"Invalid request","Title":"Bad Request","header":"Bad Request","text":"Invalid request"}}

If I copy the password with browserpass paste it in manually, submit works fine. If I set autoSubmit: false, and just use browserpass to fill the form, submit also works fine.

maximbaz commented 6 years ago

I have a strong suspicion that this will be solved by #261, when browserpass learns how to submit those special forms. Let's keep this open and verify once that ticket is solved.

maximbaz commented 5 years ago

The page with json error has been solved in https://github.com/browserpass/browserpass-extension/pull/52

Because AWS uses non-standard HTML markup, Browserpass is unable to detect the login button. In v3 (#331) I implemented a way to make Browserpass fake Enter keypress for you (https://github.com/browserpass/browserpass-extension/pull/55), but sadly this only works in Chromium(-based?) browser, not in Firefox.