added dark theme css, options, and injection javascript

browserpass / browserpass-legacy

Legacy Browserpass repo, development is now happening at:

https://github.com/browserpass/browserpass-extension

MIT License

999 stars 80 forks source link

added dark theme css, options, and injection javascript #269

Closed bhhaskin closed 5 years ago

bhhaskin commented 6 years ago

First attempt at adding a dark theme based off Firefox's dark theme.

Added dark-theme CSS. Check box option in the options page. Added dark icon SVGs.

The CSS just overrides colors, border colors and SVG backgrounds. SVG Icons are the same as the originals but with different color fills and strokes.

This resolves #243

bhhaskin commented 6 years ago

Injecting the style sheet isn't great, but I couldn't see a way to do it with mithril.js

maximbaz commented 6 years ago

Huge thanks for looking into it @bhhaskin, I want to use the dark theme myself 🙂

Just to let you know, we are in the middle of developing a next major version of browserpass, which is a complete rewrite and has a bit different design. We had a pause recently, but planning to resume the work soon. Not every feature is ported yet, so the markup and design is still changing. Let me ping you once the UI stabilizes so that you can rebase your improvement on the v2.

bhhaskin commented 6 years ago

@maximbaz sure thing! Thanks!

maximbaz commented 5 years ago

@bhhaskin thanks again for the PR, we have settled on the following design in v3, it has been merged and will be part of the next release.

bhhaskin commented 5 years ago

Awesome! It looks fantastic!