Closed maximbaz closed 5 years ago
I like this idea. I think it should have a toggle in the options to enable / disable it, but it does seem like something that would be useful.
Here's a second pass at this two-line popup design. Consider the following password-store which has been deliberately constructed to show the different cases in one screenshot:
There's a lot of duplication in this directory structure because it's mixing organizational models in under one password-store. Let met define some terminology inspired by a GTD implementation called Things for this discussion:
@ipundit I'm strongly opposed to a breadcrumb interface as proposed above.
It's visually cluttered, and considerably more difficult to parse at a glance. The constantly changing contrast within a single entry is a hindrance to reading it quickly.
There are insufficient distinctive colours available to allocate to each unique directory name without repetition. If the colours cannot be relied upon to be unique, then the colour alone is insufficient to quickly distinguish the entry.
Clickable breadcrumb filtering introduces a significant divergence between keyboard and mouse navigation, and it's a feature that can't be easily made keyboard-compatible in a manner that is not somewhat cumbersome.
It feels over-complicated, and IMO is trying to solve a problem (easy search refinement) that is already solved, while simultaneously making the UX worse. I concede it looks attractive, but looking attractive is a lower priority than good UX.
Pick one folder organisation strategy and stick with it rather than mixing organisational models.
This is outside the scope of what browserpass can or should determine. Yes, it's ideal in probably the majority of cases, but the nature of pass
is such that the user can choose to organise things any way they'd like - it's fundamentally just files in a directory. Furthermore, different styles of organisation suit different users - there isn't One Right Way of doing things.
Document the pros and cons of each folder organisation strategy.
Perhaps. This is still out of scope for browserpass though. It's a frontend for a pass
store; it's not a full-stack password manager in the same way that e.g. LastPass is.
If browserpass really wants to be folder-structure agnostic, then it has to provide an interface to select which logins should be shared with the executive assistant rather than relying on all those logins to be under the Consulting Area of Responsibility.
Why? The user already has full control over the folder structure; if they feel that they need some way of distinguishing a particular subset of logins, even across different stores, then they are free to organise things in a way that facilitates this. I don't see why this needs a dedicated feature within browserpass. Could you expand a bit on why you think this is necessary, and how you envisage such a thing being implemented without breaking compatibility with pass
?
Its current multiple password-storage support favours a Things-like, rather than domain-first organisation structure because a password storage root lives at the root of its directory tree.
There is nothing requiring you to organise things this way. Multiple stores are supported, because it's common for people to need unified access to multiple stores. That doesn't mean you need to split your own logins across multiple stores; there's nothing preventing you from using a domain-first approach in a single store, if that's what you want to do.
It's also worth bearing in mind, that in a multiple-stores approach, the user doesn't necessarily have control of all the stores. They may have read-only access to stores which are outside of their control, and the way those stores are organised may not be the same.
The next version of browserpass will have two-lines design:
Idea described in https://github.com/browserpass/browserpass/issues/272#issuecomment-403084765
This needs some extra thought, for now I just want to track this in a separate ticket so that I don't forget about it.