Extension Windows path support

browserpass / browserpass-legacy

Legacy Browserpass repo, development is now happening at:

https://github.com/browserpass/browserpass-extension

MIT License

999 stars 80 forks source link

Extension Windows path support #278

Closed ghost closed 5 years ago

ghost commented 6 years ago

General information

Operating system + version: Windows 10
Browser + version: Chromium 67.0.3396.99 (64-bit)
Information about the host app:
- How did you install it?
- Pre-built binary
- If installed an official release, put a version: 2.0.21
Information about the browser extension:
- Installed via webstore
- Browserpass extension version as reported by your browser: 2.0.21

Exact steps to reproduce the problem

Create new Password Store location in Extension options
Enter Windows path to location

What should happen?

Passwords should show up and work

What happened instead?

Passwords show up prefixed with path and do not work

erayd commented 6 years ago

Hi @braderhart - could you please provide a screenshot? Files are supposed to be listed with a path prefix relative to the store root.

When you say they "do not work", what exactly happens, and what were you expecting?

ghost commented 6 years ago

Options My options.

Links Default .password-store users disappear

Error Error on selecting password option.

What I would like to happen if possible, is an option to merge the passwords display so they work without the prefix and no error too if possible.

erayd commented 6 years ago

@braderhart What you're asking for already exists, if I understand you correctly :-).

When you set up custom store locations, this overrides the default. What your screenshot shows is that you have only one store configured - C:\Users\berhart\.password-store-brad.

In order to display merged results, you need to configure more than one store:

Name	Path
Default	C:\Users\berhart\.password-store
Brad	C:\Users\berhart\.password-store-brad

Removing the prefix is also a thing - you simply need to provide a name for your configured stores. If a name is available, then the prefix is removed and the store name is displayed instead.

erayd commented 6 years ago

@maximbaz I think there's a bug in here also - based on @braderhart's screenshot, it looks like when a custom store is configured with no name, then something strange is happening with the prefix when fetching the file. I will look into this...

ghost commented 6 years ago

@erayd This works perfectly now. Thanks!

maximbaz commented 5 years ago

I believe this has been fixed in v3, if you can test now, please share your feedback in https://github.com/browserpass/browserpass/issues/331