OTP button must be disabled for records without OTP

browserpass / browserpass-legacy

Legacy Browserpass repo, development is now happening at:

https://github.com/browserpass/browserpass-extension

MIT License

998 stars 87 forks source link

OTP button must be disabled for records without OTP #321

Closed 532910 closed 5 years ago

532910 commented 5 years ago

The "Copy OTP code" button must not be shown at all or be disabled for records that has no otpauth record. "Error: Unable to determine the OTP code for this entry." is the worst behavior.

maximbaz commented 5 years ago

yeah unfortunately it's not possible, because you need to decrypt the entry before you can know if it has OTP or not, and I shared elsewhere that it's very costly operation and definitely not going to happen.

We are considering though to remove the OTP button and add "Copy OTP" in right click menu, and lately I've been thinking about removing OTP functionality altogether (#322).

532910 commented 5 years ago

Oh, sorry, I realized that it's impossible. Can I close it?