browserpass / browserpass-legacy

Legacy Browserpass repo, development is now happening at:
https://github.com/browserpass/browserpass-extension
MIT License
998 stars 87 forks source link

CTRL+Shift+L not working for MacOS and Firefox Quantum #326

Closed chrisalcantara closed 5 years ago

chrisalcantara commented 5 years ago

General information


Exact steps to reproduce the problem

  1. Open firefox in MacOS with latest browserpass-ce addon
  2. Go to website with password prompt
  3. Hit CTRL+SHIFT+L

What should happen?

Password prompt should appear

What happened instead?

Noting

Description

I've gone through the issues in this repo but yet to see anything about CTRL+SHIFT+L not working in Firefox Quantum in MacOS, especially 10.12+.

I tried this addon in chromium, and the shortcut works, meaning the OS isn't hogging the key. I have an Arch-based machine at home, and the shortcut works.

I went through the process mentioned in #185 of downloading the add-on, changing the manifest.json to another shortcut, but everytime I zip it and load it into Firefox, the browser says the entire folder is corrupted. Not sure what the problem is because I'm literally changing one letter in the json file.

Any help would be great. Thanks for this great tool.

chrisalcantara commented 5 years ago

Firefox 66.0 now allows custom keyboard shortcuts for various extensions. I was FINALLY able to change my version to ctrl+shift+L for browserpass, and it works.

maximbaz commented 5 years ago

What a great news! Sorry I didn't reply sooner, I don't have a macOS to try, but I'm glad it's all solved now.