browserpass / browserpass-native

Browserpass native client app
ISC License
394 stars 50 forks source link

fedora copr #142

Closed prez closed 9 months ago

prez commented 9 months ago

https://copr.fedorainfracloud.org/coprs/maximbaz/browserpass/

Is this an officially supported installation method?

https://download.copr.fedorainfracloud.org/results/maximbaz/browserpass/pubkey.gpg does not seem to match https://maximbaz.com/pgp_keys.asc (disclaimer: I don't really have a clue about proper gpg use)...

maximbaz commented 9 months ago

I can confirm that it was indeed created by me, I made it because right now I use fedora, and yes it installs browserpass according to the official documentation. I haven't fully decided yet if I'm going to add it to this repo as the official recommended way yet, but very likely that I will.

prez commented 9 months ago

Thank you very much for confirming this and making it conveniently available for fedora users!

prez commented 9 months ago

@maximbaz I was wondering why the package from the copr does not work, and I think you got the external_crx field in the .json extension descriptor wrong:

{
    "external_crx": "/usr/lib64/browserpass-chromium/browserpass-chromium-3.8.0.crx",
    "external_version": "3.8.0"
}
~ $ dnf repoquery -l browserpass-chromium
...
/usr/lib64/browserpass-chromium/browserpass-github-3.8.0.crx
/usr/share/chromium/extensions/pjmbgaakjkbhpopmakjoedenlfdmcdgm.json
...

The filename of the crx should be browserpass-chromium-3.8.0.crx, not browserpass-github-3.8.0.crx.

maximbaz commented 9 months ago

Oh big thanks for the catch! It shows I use firefox in daily usage :sweat_smile: :see_no_evil: Pushed the fix now, hopefully.

prez commented 6 months ago

Sorry to bother you again. I'm switching to brave due to its superior fingerprinting protection, and noticed the extension is installed there by default as well just because I have the browserpass-chromium package on my fedora installation.

However, when activating the extension it is stuck on Loading available logins.... I know it's a lot to ask for, but is this perhaps something that could be fixed with the copr packaging? Thank you!

maximbaz commented 6 months ago

Hey! I ended up not using Fedora in the end, so I dont think I'll be maintaining that copr - however would you like to take over that copr? (or maybe rather create one in your name). In which case I'm happy to share the spec file!

maximbaz commented 6 months ago

As for the brave browser, to make it work you can either follow the README to execute the make hosts-brave-user, or extend the fedora copr with support for brave by implementing this part there, by using chromium support as an example: https://github.com/browserpass/browserpass-native/blob/c4c71108293b259bf592ec5d9a7f13559a5f8fca/Makefile#L354

prez commented 6 months ago

Hey! I ended up not using Fedora in the end, so I dont think I'll be maintaining that copr - however would you like to take over that copr? (or maybe rather create one in your name). In which case I'm happy to share the spec file!

I am honoured by this offer, but I will have to decline. I don't think having such a critical piece of software maintained by an anonymous internet weirdo is a good idea. At least it isn't what I would like to see as a user myself.

Installing via the makefile shouldn't be a big issue, if you have no bandwidth to maintain the copr, which I totally understand.