search

browserpass / browserpass-otp

OTP functionality for browserpass
ISC License
24 stars 2 forks source link

Dark theme #15

Open 532910 opened 4 years ago

532910 commented 4 years ago

image

532910 commented 4 years ago

And image

apiraino commented 4 years ago

Hi @532910 I tried to reproduce this on Firefox Linux 73.0b12 with standard dark mode but I didn't succeed:

2020-02-09_11-02-1581244199

Just a thought, what happens if you switch to the "Light" theme and then back to "Dark"?

Also: what happens if you override the CSS forcing black text color?

You can quickly hack a test renaming the extension package .xpi to .zip file in your firefox profile directory, edit the file "css/popup.dist.css", rename the file back to .xpi and then restart Firefox

532910 commented 4 years ago

On your screenshot it is light, so you reproduce it. This issue is not about grey on white, but about dark theme.

532910 commented 4 years ago

If you'd like to reproduce my screenshot you can try browser.in-content.dark-mode=true, widget.content.allow-gtk-dark-theme=true, browser.display.use_system_colors=true and $GTK_THEME=Adwaita:dark

apiraino commented 4 years ago

now I can reproduce, thank you :) I'll have a look at it, just out of curiosity