browserquest / BrowserQuest

Continuing the development of Mozilla BrowserQuest
http://browserquest.herokuapp.com
Other
444 stars 220 forks source link

Security Concerns #27

Open Mawgamoth opened 11 years ago

Mawgamoth commented 11 years ago

Hi,

I know that player data is stored client side and can be accessed and changed, but outside of that is there anything else that I should be concerned about? Are there any plans to add functionality for storing and propagating player data from the server side? Is this something that I could help with?

lzbk commented 11 years ago

Hi, it is not on my sprint backlog. But it is definitely in my product backlog. For our project, we want the game to be both accessible from home, but also in the city (the url feature I added will mostly serve to unlock achievements through QR codes when the user solves enigmas by finding an artefact in the city). Therefore the same player will need to be able to access the game from their computer and their phone. Hence my need to store the data on the server. I figured it would be useful to you for the security concerns I evoked. I believe that Jérôme and his team are also interested in such a feature, which has side effects, such as authentication. If some of you guys are interested in developing such a feature, I'll catch up with you on my next sprint otherwise, I'll probably start working on that in a few weeks anyway. Cheers

Mawgamoth commented 11 years ago

I'd like to take a stab at it, but not sure if I will be able to for the time being. Still wrapping my head around the BrowserQuest source code.

Mawgamoth commented 11 years ago

Adding database support is something I am currently looking into, and will be attempting an initial implementation of here sometime soon.