search

browserquest / BrowserQuest

Continuing the development of Mozilla BrowserQuest
http://browserquest.herokuapp.com
Other
445 stars 219 forks source link

Keyboard Movement Changes #28

Closed Mawgamoth closed 11 years ago

Mawgamoth commented 11 years ago

I made some changes to fix and smooth out keyboard movement. Also discovered and fixed a rare bug, which became especially prevalent with my recent changes to keyboard movement.

The changes/commits are available on the repository that I forked at https://github.com/Mawgamoth/BrowserQuest, if anyone would like to check them out or review them. Perhaps they can be merged into the main BrowserQuest repository?

Also, not sure if I should be communicating here, or via the mailing list.

Let me know what you think!

justinclift commented 11 years ago

That sounds cool. Keyboard movement is my preferred way of doing things, and it's definitely a bit buggy at the moment.

Would you be ok to create a pull request with the changes? (preferably with everything squashed into one commit) :)

Mawgamoth commented 11 years ago

Submitted pull request. Had a bit of an issue with squashing all the commits into one, I'm new to github so the various terminology and methodology was confusing me a bit. Ended up just deleting my repository and reforking, then commited all changes as one commit.

justinclift commented 11 years ago

Excellent Jason, and no worries. The end result is the important thing. :)

As a thought, I generally squash commits from the command line interface instead of trying to do it with GitHub.

From the command line, you do something like "git reset commit identifier here", making sure you don't use the "--hard" option. That resets the git tree back to whichever commit you point it at, but without reverting the files.

i.e. so if you've got 3 files, a.txt, b.txt, and c.txt, you could do a "git reset some_older_commit" to move your commit history back a few, but leave the new files in place. Doing a "git status" will show the changed files, so you can then do a "git add" on them and "git commit" them to capture everything as one new commit.

Not sure if I'm explaining that in any kind of useful way though. :)

justinclift commented 11 years ago

Closing this issue, because the pull request (#29) you made for it has been merged. :)

Mawgamoth commented 11 years ago

Thanks for the tip, I'll keep it mind for the future!