browserstack / browserstack-local-java

Java bindings for BrowserStack Local
https://www.browserstack.com
MIT License
18 stars 33 forks source link

Local identifier isn't used when calling Local.stop(); *all* instances of BrowserStackLocal are stopped. #34

Open rlundy opened 5 years ago

rlundy commented 5 years ago

When calling Local.stop() with a local identifier, this library doesn't appear to actually use the local identifier when stopping BrowserStackLocal. Consequently, if multiple BrowserStackLocal instances are running as daemons with different identifiers, all are stopped.

(Compare with using the executable, BrowserStackLocal.exe, with --daemon start. In that case, the local identifier is used, and only that instance is stopped. If the identifier is omitted, then all instances are stopped.)

Expected Behavior

If an identifier is provided, then calling Local.stop() should only stop any BrowserStackLocal instances with the corresponding identifier.

Actual Behavior

Even if an identifier is provided, calling Local.stop() stops all BrowserStackLocal instances without regard to their identifiers.

bipul21 commented 5 years ago

Hi,

We are able to replicate this issue when you use the identifier like abcd and abcd1 and call .stop on one of them both the instances gets killed. The problem is in the BrowserStack Local Binary, we will fix the same in our next release and let you know here as well.

In the meanwhile you can generate a unique identifer like uuid and use the same in which case it should work as expected.

Apologies for the delay in responding here.