Use the configured proxy host and port for the download

browserstack / browserstack-local-nodejs

NodeJS bindings for BrowserStack Local

https://www.browserstack.com

MIT License

71 stars 56 forks source link

Closed mohlendo closed 8 years ago

mohlendo commented 8 years ago

Sadly for https download over proxy, we need a special http agent implementation. Added a simple one, too.

Fixes #14

nidhimj22 commented 8 years ago

@mohlendo Can you please fix the tests?

mohlendo commented 8 years ago

@nidhimj22 I have fixed the test. But the error wasn't related to my changes - should have been there before...

nidhimj22 commented 8 years ago

@mohlendo Thanks! Can you also write a test case for this? You can mock the proxy.

tr4n2uil commented 8 years ago

Awesomeness! Thanks @mohlendo