Ensure calling .stop does not error if callback is not passed in

browserstack / browserstack-local-nodejs

NodeJS bindings for BrowserStack Local

https://www.browserstack.com

MIT License

71 stars 56 forks source link

Closed ldabiralai closed 7 years ago

ldabiralai commented 7 years ago

Before this PR calling .stop() without a callback would error

jamesaspence commented 7 years ago

I created a very similar PR (https://github.com/browserstack/browserstack-local-nodejs/pull/35) that adds an optional callback to start as well as stop :)

jamesaspence commented 7 years ago

Perhaps we can merge these two PRs into one?

vedharish commented 7 years ago

Please see #35