search

browserstack / browserstack-local-nodejs

NodeJS bindings for BrowserStack Local
https://www.browserstack.com
MIT License
71 stars 56 forks source link

Fix argument order sent via command line to browserstack local binary. #38

Closed stevenlybeck closed 6 years ago

stevenlybeck commented 7 years ago

Previously, the folder flag and folder value were split by the key argument.

stevenlybeck commented 7 years ago

If you logged the output of this.getBinaryArgs().join(" ") right before it gets passed to execFile() - you find that this is the output:

-f --key 00000000000000000 /folder/option/string/goes-here

This PR brings the -f flag and folder string back together.

pankaj-a commented 6 years ago

Merged in #62. Closing this. Thanks @stevenlybeck for the fix.