Stop doesn't stop if the daemon is already running.

browserstack / browserstack-local-nodejs

NodeJS bindings for BrowserStack Local

https://www.browserstack.com

MIT License

71 stars 56 forks source link

Stop doesn't stop if the daemon is already running. #45

Closed BenPatterson2 closed 6 years ago

BenPatterson2 commented 6 years ago

Not sure why, but the calling bs_local.stop() does not work reliably and I get into a state where I can't connect properly. Running it again, I get this error.

{ LocalError: Either another browserstack local client is running on your machine or some server is listening on port 45691
....

Think this isn't a real bug but would like the bs_local.stop command to have an option to stop the binary daemon regardless of whether it started it or not.

Will have a PR up for this shortly

BenPatterson2 commented 6 years ago

Nevermind. This fixed my issue

bs_local_args = { 'key': '<browserstack-accesskey>', 'force': 'true' }