browserstack / browserstack-local-nodejs

NodeJS bindings for BrowserStack Local
https://www.browserstack.com
MIT License
71 stars 56 forks source link

update https-proxy-agent to fix vulnerability #49

Closed evan-scott-zocdoc closed 6 years ago

evan-scott-zocdoc commented 6 years ago

Fixes https://nodesecurity.io/advisories/593

Looked at the changelog and it doesn't appear there is any breaking change relevant to the library.

https://github.com/TooTallNate/node-https-proxy-agent/blob/master/History.md#200--2017-06-26

mohitmun commented 6 years ago

@evan-scott-zocdoc Did you try running tests locally? travis build is failing since credentials are outdated. we are fixing it soon

evan-scott-zocdoc commented 6 years ago

One of the tests failed for me locally, but the same tests fails for me too on master. So I don't know what's up.

screen shot 2018-05-18 at 2 20 20 pm

(latest macOS, node 8.11.2)