search

browserstack / browserstack-runner

MIT License
130 stars 61 forks source link

Correctly set config fields defined as env variables #223

Closed DanielRuf closed 4 years ago

DanielRuf commented 4 years ago

Currently browserstacl-runner checks if there is a username field in the json file.

https://github.com/browserstack/browserstack-runner/blob/1df5c7e5bcf67b21e927e197bc595db27ec88c3a/lib/config.js#L57

But this is not needed and removed when the relevant env setting is provided.

https://github.com/browserstack/browserstack-runner/blob/1df5c7e5bcf67b21e927e197bc595db27ec88c3a/lib/config.js#L37

DanielRuf commented 4 years ago

Proposed solution: set config.username = this.username, same for key.