search

browserup / browserup-proxy

BrowserUp Proxy is a free utility to watch, test, and manipulate web application network traffic and performance.
https://browserup.com
Apache License 2.0
164 stars 41 forks source link

Enable non proxy host support for upstream proxies. #224

Closed erickubenka closed 4 years ago

erickubenka commented 4 years ago

Hi folks,

at first I want to thank you, that you forked browsermob-proxy repository and keep the project alive. But I encountered a problem while using upstream proxy servers. I will explain the problem to you and provide a solution with this pull request.

In my company we work with a company proxy server. This proxy server is mostly set as upstream proxy in our projects that use browserup proxy.

In a real world scenario I may want to specifiy upstream proxy exceptions or may known as "nonproxyhosts". Java or JDK allows me to pass in these nonProxyHosts with http.nonProxyHosts option, but this option is completely ignored for running browser up instances, as well as there is no option to set a non proxy host to the given upstream proxy.

For clarification I just will add you this "image" to let you know about the architecture I mostly work on.

At least: Keep the good work up and let me know, if I should change or explain something.

image

erickubenka commented 4 years ago

I updated the branch with a new testcase and the "wildcard" macthing feature as well.

raydenx commented 4 years ago

@erickubenka Thanks for implementing this feature! This is exactly what we need. @dpowell Can't wait to see it in release build. When can we expect it?

dpowell commented 4 years ago

Thanks for the nudge @raydenx :

https://github.com/browserup/browserup-proxy/releases/tag/v2.1.0

raydenx commented 4 years ago

Thanks! @dpowell