search

browserup / browserup-proxy

BrowserUp Proxy is a free utility to watch, test, and manipulate web application network traffic and performance.
https://browserup.com
Apache License 2.0
164 stars 41 forks source link

Doesn't work as expected with JDK10+ #245

Closed doublemarket closed 4 years ago

doublemarket commented 4 years ago

Describe the bug

When using browserup-proxy with JDK10+, it's not possible to set a custom port when creating a new proxy config. This is because parsing the data in a POST request doesn't work as expected because mvel which is contained in browserup-proxy can't run with JDK10+ with an issue.

To Reproduce

Refer to the issue https://github.com/autifyhq/docker-browserup-proxy/issues/2 as well.

Steps to reproduce the behavior:

  1. Start browserup-proxy with JDK10+ (I tested with JDK14).
  2. Issue a POST request to /proxy with the 'port=8099' data.
    • The result is same when providing the data with JSON ({"port":8099}).
    • Other options as well. I didn't try with every option but trustAllServers can't be set as well.
  3. browserup-proxy returns a 500 error.

Expected behavior

browserup-proxy should return a port number when hitting with the port number.

Screenshots If applicable, add screenshots to help explain your problem.

Please complete the following information:

Additional context

Providing the version info to mvel by adding a line in the browserup-proxy code is an option.

doublemarket commented 4 years ago

Note that this is confirmed with 2.0.1.

ericbeland commented 4 years ago

Can you confirm this with the latest and reopen if it still occurs?

weendigo commented 4 years ago

I can't figure how to reopen but the #277 was closed as duplicate of this one and that is repro with 2.1.0 and 2.1.1 as well.