search

browserup / browserup-proxy

BrowserUp Proxy is a free utility to watch, test, and manipulate web application network traffic and performance.
https://browserup.com
Apache License 2.0
164 stars 41 forks source link

Support wildcard for Basic auth domains #266

Open doublemarket opened 4 years ago

doublemarket commented 4 years ago

By merging this PR, the domain name for a basic auth setting allows wildcards (*). e.g. *.example.com matches foobar.example.com, * matches any hostname.

Note that I confirmed that this passes tests on the latest master branch but the jar file based on it doesn't work due to the #263. I confirmed the jar file generated based on 2.0.1 + changes in this PR works.

ericbeland commented 4 years ago

We have some big changes coming in about a month. We're trying an approach to drop littleproxy. I feel bad about it, but I think the basic auth part just got hit with a minor rewrite. I'd like to review when that change lands.

doublemarket commented 4 years ago

@ericbeland Wow, that's a big news! I'm looking forward to see the changes. Please review if this PR still has some values with the new version. Otherwise... heh, no worries 😄