proxy cannot be restarted

[2x2xplz]

Describe the bug proxy thinks it is in both started and stopped modes simultaneously. This is a problem because it cannot be restarted (throws an IllegalState error)

To Reproduce Steps to reproduce the behavior (Kotlin):

val buProxy : BrowserUpProxyServer = BrowserUpProxyServer().apply { this.start(8002) }
... drive some Selenium code ...
buProxy.stop()
println(buProxy.isStarted && buProxy.isStopped) // returns true

Expected behavior after buProxy.stop() , I expect isStarted to be false, and subsequent buProxy.start() command would not throw an "already started" error

Screenshots

Please complete the following information:

• OS: Windows 10 64-bit
• Chrome (as the webdriver)
• Version 2.1.1
• Java 11

Additional context Same behavior exists in BrowserMob. I "upgraded" to BrowserUp, thinking this may have been fixed, but seeing the same issue in both packages.

[2x2xplz]

not sure why I didn't see this earlier, but apparently this behavior is originally by design: https://github.com/lightbody/browsermob-proxy/issues/264#issuecomment-112933259

BMP is not currently meant to be stopped and restarted.

With that said, this is a new project and new company, perhaps it is worth reconsidering whether no-restarts is the best option, or if it should be implemented.

[ericbeland]

We have a new implementation coming out. I'm closing for now. I think we may end up doing this along the way, though.